Fix toIpInAgg & toIpInSort #129743
Merged
Fix toIpInAgg & toIpInSort #129743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idegtiarenko
added
>test-failure
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
needs:risk
idegtiarenko
commented
Jun 20, 2025
| @@ -317,7 +317,7 @@ FROM logs | |||
| 2023-10-23T13:55:01.546Z| java|More java stuff |null | |||
| ; | |||
|
|
|||
| toIpInAgg | |||
| toIpInAgg#[skip:-8.12.99,reason:StatsNestedExp introduced in v8.13.0] | |||
There was a problem hiding this comment.
This relies on #104387 added in 8.13
idegtiarenko
commented
Jun 20, 2025
| ROW s = "1.1.1.1" | STATS COUNT(*) BY ip = TO_IP(s) | ||
| ; | ||
|
|
||
| COUNT(*):long | ip:ip | ||
| 1 | 1.1.1.1 | ||
| ; | ||
|
|
||
| toIpInSort | ||
| toIpInSort#[skip:-8.13.99,reason:SortByExpression introduced in 8.14] |
There was a problem hiding this comment.
This relies on #107158 added in 8.14
idegtiarenko
added
>test
💚 Backport successful
|
idegtiarenko
added a commit
to idegtiarenko/elasticsearch
that referenced
this pull request
Jun 20, 2025
This was referenced Jun 20, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 23, 2025
kderusso
pushed a commit
to kderusso/elasticsearch
that referenced
this pull request
Jun 23, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes by with expression usage in the MixedClusterEsqlSpecIT tests
Related to #129734