mimecast: Handle empty events in a time window inside threat events. #12937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kcreddy
added
Integration:mimecast
kcreddy
changed the title
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
audit_events |
3012.05 | 2298.85 | -713.2 (-23.68%) | 💔 |
message_release_logs |
4854.37 | 2747.25 | -2107.12 (-43.41%) | 💔 |
ttp_ap_logs |
8196.72 | 4651.16 | -3545.56 (-43.26%) | 💔 |
To see the full report comment with /test benchmark fullreport
kcreddy
changed the title
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
efd6
reviewed
Mar 3, 2025
Comment on lines
110
to
141
| : | ||
| // Mimecast can return failure states with a 200. This | ||
| // is detected by a non-empty fail array at the root | ||
| // of the response body. Don't attempt to parse this | ||
| // out, just dump the whole body into the error message. | ||
| { | ||
| "events": { | ||
| "error": { | ||
| "code": string(resp.StatusCode), | ||
| "id": string(resp.Status), | ||
| "message": "POST " + state.path + ": " + string(resp.Body), // We know this is not empty. | ||
| // of the response body. | ||
|
|
||
| // Mimecast threat events return fail message | ||
| // containing `err_threat_intel_feed_no_result_found` | ||
| // when no events within the query time window. | ||
| // Handle this by saving empty events array and | ||
| // not report error. | ||
| (body.?fail[?0].errors[?0].code.orValue("") == "err_threat_intel_feed_no_result_found") ? | ||
| { | ||
| "events": [], | ||
| // Override cursor to remove cursor.token if present. | ||
| "cursor": { | ||
| "last": state.?cursor.last, | ||
| }, | ||
| }, | ||
| "want_more": false, | ||
| } | ||
| "want_more": false, | ||
| } | ||
| : | ||
| // Don't attempt to parse this out, just dump the whole | ||
| // body into the error message. | ||
| { | ||
| "events": { | ||
| "error": { | ||
| "code": string(resp.StatusCode), | ||
| "id": string(resp.Status), | ||
| "message": "POST " + state.path + ": " + string(resp.Body), // We know this is not empty. | ||
| }, | ||
| }, | ||
| "want_more": false, | ||
| } |
There was a problem hiding this comment.
Suggest instead
diff --git a/packages/mimecast/data_stream/threat_intel_malware_customer/agent/stream/cel.yml.hbs b/packages/mimecast/data_stream/threat_intel_malware_customer/agent/stream/cel.yml.hbs
index c0b6b57272..b65f136681 100644
--- a/packages/mimecast/data_stream/threat_intel_malware_customer/agent/stream/cel.yml.hbs
+++ b/packages/mimecast/data_stream/threat_intel_malware_customer/agent/stream/cel.yml.hbs
@@ -107,9 +107,23 @@ program: |
},
"want_more": resp.?Header["X-Mc-Threat-Feed-Next-Token"].hasValue(),
}
+ : (body.?fail[0].errors[0].code.orValue("") == "err_threat_intel_feed_no_result_found") ?
+ // Mimecast threat events return fail message
+ // containing 'err_threat_intel_feed_no_result_found'
+ // when no events within the query time window.
+ // Handle this by saving empty events array but
+ // do not report an error.
+ {
+ "events": [],
+ // Override cursor to remove cursor.token if present.
+ "cursor": {
+ "last": state.?cursor.last,
+ },
+ "want_more": false,
+ }
:
- // Mimecast can return failure states with a 200. This
- // is detected by a non-empty fail array at the root
+ // Mimecast can also return other failure states with a 200.
+ // This is detected by a non-empty fail array at the root
// of the response body. Don't attempt to parse this
// out, just dump the whole body into the error message.
{
efd6
approved these changes
Mar 4, 2025
chrisberkhout
approved these changes
Mar 4, 2025
💚 Build Succeeded
History
cc @kcreddy |
|
|
Package mimecast - 2.6.2 containing this change is available at https://epr.elastic.co/package/mimecast/2.6.2/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Note
Can be merged after #12936 (2.6.1) do avoid version conflict
Checklist
changelog.ymlfile.How to test this PR locally
System tests pass