Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

box_events: handle collaboration invite events and improve user field handling #12944

Merged
merged 3 commits into from
Mar 4, 2025
Merged

box_events: handle collaboration invite events and improve user field handling #12944

merged 3 commits into from
Mar 4, 2025

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 3, 2025 •
edited
Loading

Proposed commit message

box_events: handle collaboration invite events and improve user field handling

Map user details from invite events and improve handling of related.user.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:box_events Box Events Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations] labels Mar 3, 2025
@efd6 efd6 self-assigned this Mar 3, 2025
@efd6 efd6 force-pushed the 12920-box_events branch 2 times, most recently from 382d619 to e20da56 Compare March 3, 2025 23:04
@elastic-vault-github-plugin-prod
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review March 3, 2025 23:27
@efd6 efd6 requested a review from a team as a code owner March 3, 2025 23:27
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

chrisberkhout
chrisberkhout approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog description could be clarified

packages/box_events/changelog.yml Outdated
@@ -1,4 +1,9 @@
# newer versions go on top
- version: "2.12.0"
changes:
- description: Add missing ECS mappings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also retains other fields. This description could be updated to be a closer match for the proposed commit message.

@efd6 efd6 force-pushed the 12920-box_events branch from 478a8a9 to 386a0ff Compare March 4, 2025 21:01
@efd6 efd6 force-pushed the 12920-box_events branch from 386a0ff to 528bc5a Compare March 4, 2025 21:04
@efd6 efd6 changed the title box_events: handle collaboration invite events box_events: handle collaboration invite events and improve user field handling Mar 4, 2025
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@efd6 efd6 merged commit d340fe1 into elastic:main Mar 4, 2025
7 checks passed
@elastic-vault-github-plugin-prod
Copy link

Package box_events - 2.13.0 containing this change is available at https://epr.elastic.co/package/box_events/2.13.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisberkhout chrisberkhout chrisberkhout approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:box_events Box Events Team:Security-Service Integrations Security Service Integrations Team [elastic/security-service-integrations]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[box_events]: doesn't set user.??? fields, as well as user.target.???? for event.action COLLABORATION_INVITE
3 participants
@efd6 @elasticmachine @chrisberkhout