Skip to content

[ti_anomali] Modify field type to eliminate field conflicts within the data streams. #13909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

brijesh-elastic
Copy link
Contributor

Proposed commit message

ti_anomali: resolve field data type conflicts between data streams

This introduces a breaking change by altering the field type from 'long' to
'keyword' for the 'import_session_id', 'trusted_circle_ids', and 'update_id' fields,
and from 'short' to 'long' for the 'confidence' field.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

How to test this PR locally

  • Clone integrations repo.
  • Install elastic package locally.
  • Start elastic stack using elastic-package.
  • Move to integrations/packages/ti_anomali directory.
  • Run the following command to run tests.

elastic-package test

Related issues

@brijesh-elastic brijesh-elastic self-assigned this May 14, 2025
@brijesh-elastic brijesh-elastic requested a review from a team as a code owner May 14, 2025 10:02
@brijesh-elastic brijesh-elastic added Integration:ti_anomali Anomali bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels May 14, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented May 14, 2025

🚀 Benchmarks report

Package ti_anomali 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
threatstream 5235.6 3676.47 -1559.13 (-29.78%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @brijesh-elastic

@brijesh-elastic brijesh-elastic requested a review from efd6 May 15, 2025 06:21
description: >-
IDs of the trusted circles with which the indicator is shared.
- name: type
type: keyword
description: >-
Type of indicator—domain, email, ip, md5, string, url.
- name: update_id
type: long
type: keyword
Copy link
Contributor

@kcreddy kcreddy May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During integration upgrade, the source data stream-backed indices are rolled over, which doesn't cause conflicts during indexing.
But the destination indices aren't data stream backed, hence they wouldn't roll over. This will cause indexing failures because of mapping conflicts. You will also need to update transform's destination index suffix, and also fleet_transform_version to actually update the transform.

Please also test the upgrade process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue Integration:ti_anomali Anomali Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ti_anomali] Field data type conflicts between data streams
4 participants