[aws] Update Grok pattern to support new HTTP ELB log format #13944
+62
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devamanv
added
enhancement
💔 Build Failed
Failed CI StepsHistory |
ritalwar
reviewed
May 20, 2025
| @@ -1,4 +1,9 @@ | |||
| # newer versions go on top | |||
| - version: "3.3.2" | |||
There was a problem hiding this comment.
Suggested change
| - version: "3.3.2" | |
| - version: "3.4.0" |
Since this is an enhancement, should we consider increasing the minor version instead of the patch version, which is typically for bug fixes?
efd6
reviewed
May 21, 2025
| 2024-11-29T13:45:24.599544Z 172.31.43.26 58206 80 - - - "-" - - - TID_16132ed0b4112148 | ||
| http 2025-05-01T11:24:32.748149Z app/internal-service-alb/abcd1234efgh5678 127.0.0.1:57273 - -1 -1 -1 200 - 0 272 "- http://internal-service-alb.example.com:80-/ " "-" - - - "-" "-" "-" - 2025-05-01T11:24:32.720000Z "-" "-" "-" "-" "-" "-" "-" TID_00000000000000000000000000000000 |
| @@ -1,4 +1,9 @@ | |||
| # newer versions go on top | |||
| - version: "3.3.2" | |||
| changes: | |||
| - description: Update Grok pattern to support new ELB HTTP log format. | |||
There was a problem hiding this comment.
"new" is a term that goes stale. Is there a version number or documentation that details this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The PR contains changes to modify the ELB HTTP Grok pattern to support the new log format, which is as follows:
Checklist
changelog.ymlfile.Author's Checklist
Related issues