Skip to content

[apm]: Document sampling.tail.discard_on_write_failure config #4908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 8.x
Choose a base branch
from

Conversation

isaacaflores2
Copy link

Description

Adding description for new config that will be available on v8.19+. The description matches the one provided in the v9.1.0 docs: elastic/docs-content#1453

Documentation sets edited in this PR

Check all that apply.

  • Stateful (docs/en/observability/*)
  • Serverless (docs/en/serverless/*)
  • Integrations Developer Guide (docs/en/integrations/*)
  • None of the above

Related issue

Closes elastic/apm-server#15330

Checklist

  • Product/Engineering Review
  • Writer Review

Follow-up tasks

Select one.

  • This PR does not need to be ported to another doc set because:
    • The concepts in this PR only apply to one doc set (serverless or stateful)
    • The PR contains edits to both doc sets (serverless and stateful)
  • This PR needs to be ported to another doc set:
    • Port to stateful docs: <link to PR or tracking issue>
    • Port to serverless docs: <link to PR or tracking issue>

Testing

I kept getting the below error building the docs locally when running ../docs/build_docs --doc docs/en/observability/apm/configure/sampling.asciidoc --resource ../apm-server --resource ../ingest-docs/docs --open

INFO:build_docs:/docs_build/resources/asciidoctor/lib/chunker/extension.rb:102:in `page_containing': undefined method `context' for nil:NilClass (NoMethodError)

I validated with asciidoc plugin instead:

image

@isaacaflores2 isaacaflores2 requested a review from a team as a code owner June 27, 2025 21:17
@isaacaflores2 isaacaflores2 added the backport-8.19 Automated backport to the 8.19 branch label Jun 27, 2025
Copy link
Contributor

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@isaacaflores2
Copy link
Author

[For reviewers] Note sure which Follow Up Tasks option to select and I am not sure if the backport-8.19 label is correct. Also please let me know if this PR should NOT be merged to the 8.X branch

Copy link

@vishaangelova vishaangelova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one tiny suggestion to match the docs-content PR, but otherwise LGTM

@isaacaflores2 isaacaflores2 force-pushed the tbs-config-discard-on-write branch from 956d463 to 13637d4 Compare July 1, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.19 Automated backport to the 8.19 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants