Skip to content

Commit

Permalink
[Fixes inaka#8] REJECTED: LC instead of lists:map
Browse files Browse the repository at this point in the history
  • Loading branch information
elbrujohalcon committed Sep 15, 2014
1 parent 1b268ff commit 578c131
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 1 deletion.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ I swear I heard Joe mutter this while taking a nap at the office.

One rule per issue.

When discussed and approved, it will be moved to either the *Conventions* or the *Great Ideas* list. If rejected, it will be moved to the *Rejected* list.
When discussed and approved, it will be moved to either the *Conventions* or the *Great Ideas* list. If rejected, it will be moved to the [*Rejected*](REJECTED.md) list.

### Acceptance criteria

Expand Down
25 changes: 25 additions & 0 deletions REJECTED.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
## Rejected rules and suggestions

***

##### rule
> Use tail-recursive functions instead of foldl
##### rejected because
We love high-order functions!

***

##### rule
> Using ``'andalso'``, ``'orelse'``, and the like, might save a 'case' or two
##### rejected because
They're not intended to be used that way and the resulting code messes up with dialyzer

***

##### rule
> Replace ``lists:map`` with either ``lists:foreach`` or list comprehensions
##### rejected because
There is not true that LCs are better than ``list:map`` in all scenarios.

0 comments on commit 578c131

Please sign in to comment.