-
-
Notifications
You must be signed in to change notification settings - Fork 16
Update README.md #528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update README.md #528
Conversation
WalkthroughThe README.md file was extensively rewritten to enhance clarity and focus. Key sections were restructured, value propositions were highlighted, package categories were updated, and visual explanations were simplified. Badges and historical notes were removed, and installation instructions were made more direct, with added quick links to documentation and a demo. Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (4)
README.md (4)
1-5
: Addalt
text to the logo image for accessibility
The<img>
tag only provides atitle
; screen-readers will skip the logo altogether.- <img title="elbwalker" src='https://www.elbwalker.com/img/elbwalker_logo.png' width="256px"/> + <img + src="https://www.elbwalker.com/img/elbwalker_logo.png" + width="256px" + alt="elbwalker logo" + />
15-17
: Shield badge also needsalt
text
Same MD045 warning applies to the license badge.- <img src="https://img.shields.io/github/license/elbwalker/walkerOS" /> + <img src="https://img.shields.io/github/license/elbwalker/walkerOS" alt="MIT license badge" />
9-14
: Inline link list hurts scannability
Turning the quick-links into a bulleted list makes them easier to spot and prevents horizontal scrolling on small screens.-[Read docs](https://elbwalker.com/docs) · -[Play with the demo](https://elbwalker.com/playground) · -[Request Feature](https://github.com/elbwalker/walkerOS/issues/new) · -[Report Bug](https://github.com/elbwalker/walkerOS/issues/new) · -[Say hello](https://calendly.com/elb-alexander/30min) +* [Read docs](https://elbwalker.com/docs) +* [Play with the demo](https://elbwalker.com/playground) +* [Request feature](https://github.com/elbwalker/walkerOS/issues/new) +* [Report bug](https://github.com/elbwalker/walkerOS/issues/new) +* [Say hello](https://calendly.com/elb-alexander/30min)
43-47
: Installation section could confuse newcomers
“Install a collector” comes after links to sources; readers may not yet know the difference. Consider a short, explicit one-liner:
npm i @elbwalker/collector-browser
(for client) /npm i @elbwalker/collector-node
(for server)A concrete command lowers the entry barrier.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
README.md
(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
16-16: Images should have alternate text (alt text)
(MD045, no-alt-text)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: AWS Amplify Console Web Preview
- GitHub Check: Build and test
🔇 Additional comments (1)
README.md (1)
27-35
: Package list is missing “Utils” but still referenced elsewhere
Previously there was a “Utils” section; if that package is truly gone, confirm that all internal docs/code have been updated.
## How it works | ||
|
||
 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diagram link is ephemeral – prefer a repo-local asset
user-attachments
links break once the GitHub comment is deleted or the token expires. Store the image under docs/assets/
(or similar) and reference it relatively to guarantee longevity.
🤖 Prompt for AI Agents
In README.md around lines 37 to 40, the image link uses an ephemeral GitHub
user-attachments URL that can break over time. To fix this, download the image
and store it in a local directory such as docs/assets/, then update the markdown
to reference the image using a relative path to ensure the image remains
accessible permanently.
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Summary by CodeRabbit