-
Notifications
You must be signed in to change notification settings - Fork 15.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix a syntax issue in document breaking changes #44841
Conversation
💖 Thanks for opening this pull request! 💖 Semantic PR titlesWe use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix. Examples of commit messages with semantic prefixes:
Commit signingThis repo enforces commit signatures for all incoming PRs. PR tipsThings that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
Nice, looks great. 👍 |
Congrats on merging your first pull request! 🎉🎉🎉 |
No Release Notes |
I have automatically backported this PR to "32-x-y", please check out #44903 |
I have automatically backported this PR to "33-x-y", please check out #44904 |
I have automatically backported this PR to "34-x-y", please check out #44905 |
Description of Change
Sample code written in the Breaking Changes does not work, which was added by @nornagon in #42053
Checklist
Release Notes
Notes: none