Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix a syntax issue in document breaking changes #44841

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

illusory-dream
Copy link
Contributor

@illusory-dream illusory-dream commented Nov 26, 2024

Description of Change

Sample code written in the Breaking Changes does not work, which was added by @nornagon in #42053

Checklist

  • PR description included and stakeholders cc'd
  • relevant documentation, tutorials, templates and examples are changed or added

Release Notes

Notes: none

@illusory-dream illusory-dream requested a review from a team as a code owner November 26, 2024 08:15
Copy link

welcome bot commented Nov 26, 2024

💖 Thanks for opening this pull request! 💖

Semantic PR titles

We use semantic commit messages to streamline the release process. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add app.isPackaged() method
  • docs: app.isDefaultProtocolClient is now available on Linux

Commit signing

This repo enforces commit signatures for all incoming PRs.
To sign your commits, see GitHub's documentation on Telling Git about your signing key.

PR tips

Things that will help get your PR across the finish line:

  • Follow the JavaScript, C++, and Python coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made following the documentation styleguide.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@electron-cation electron-cation bot added documentation 📓 semver/patch backwards-compatible bug fixes new-pr 🌱 PR opened in the last 24 hours labels Nov 26, 2024
@nikwen
Copy link
Collaborator

nikwen commented Nov 26, 2024

Nice, looks great. 👍

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened in the last 24 hours label Nov 27, 2024
@VerteDinde VerteDinde added target/32-x-y PR should also be added to the "32-x-y" branch. target/33-x-y PR should also be added to the "33-x-y" branch. target/34-x-y PR should also be added to the "34-x-y" branch. labels Dec 1, 2024
@VerteDinde VerteDinde merged commit 4e40b49 into electron:main Dec 1, 2024
36 checks passed
Copy link

welcome bot commented Dec 1, 2024

Congrats on merging your first pull request! 🎉🎉🎉

Copy link

release-clerk bot commented Dec 1, 2024

No Release Notes

@trop
Copy link
Contributor

trop bot commented Dec 1, 2024

I have automatically backported this PR to "32-x-y", please check out #44903

@trop trop bot added in-flight/32-x-y and removed target/32-x-y PR should also be added to the "32-x-y" branch. labels Dec 1, 2024
@trop
Copy link
Contributor

trop bot commented Dec 1, 2024

I have automatically backported this PR to "33-x-y", please check out #44904

@trop trop bot added the in-flight/33-x-y label Dec 1, 2024
@trop
Copy link
Contributor

trop bot commented Dec 1, 2024

I have automatically backported this PR to "34-x-y", please check out #44905

@trop trop bot added in-flight/34-x-y and removed target/33-x-y PR should also be added to the "33-x-y" branch. target/34-x-y PR should also be added to the "34-x-y" branch. in-flight/32-x-y labels Dec 1, 2024
@trop trop bot added merged/32-x-y PR was merged to the "32-x-y" branch. merged/33-x-y PR was merged to the "33-x-y" branch. merged/34-x-y PR was merged to the "34-x-y" branch. and removed in-flight/33-x-y in-flight/34-x-y labels Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📓 merged/32-x-y PR was merged to the "32-x-y" branch. merged/33-x-y PR was merged to the "33-x-y" branch. merged/34-x-y PR was merged to the "34-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants