refactor: return-braced-init-list pt 2 of 2 #44870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
added
semver/patch
deepak1556
approved these changes
Nov 28, 2024
|
Related, any plans to add the clang-tidy checks to the PR lint task to avoid future regressions ? |
It will need to be part off CI, rather than something that runs locally. It's incredibly slow! One idea that John suggested was to run it on changed cc files in a PR |
|
No Release Notes |
|
I was unable to backport this PR to "32-x-y" cleanly; |
trop
bot
added
needs-manual-bp/32-x-y
and removed
target/32-x-y
This was referenced Nov 29, 2024
|
I have automatically backported this PR to "33-x-y", please check out #44890 |
|
I have automatically backported this PR to "34-x-y", please check out #44891 |
trop
bot
added
in-flight/33-x-y
in-flight/34-x-y
merged/33-x-y
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Finish off the return-braced-init-list changes. Pt 1 was in #44838.
These diffs really are just a lot of
return {};and that's pretty much it 😸Checklist
npm testpassesRelease Notes
Notes: none.