Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add notifyUser option to disable the upgrade dialog prompt #46

Merged
merged 3 commits into from
Jul 10, 2019

Conversation

mvines
Copy link
Contributor

@mvines mvines commented Jun 26, 2019

Related to #22, I want a way to disable the hard coded user prompt when a new update is downloaded.

@mvines mvines changed the title Add nagUser option to disable the upgrade dialog prompt feat: add nagUser option to disable the upgrade dialog prompt Jun 26, 2019
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps notifyUser instead of nagUser?

@mvines mvines changed the title feat: add nagUser option to disable the upgrade dialog prompt feat: add notifyUser option to disable the upgrade dialog prompt Jul 10, 2019
@mvines
Copy link
Contributor Author

mvines commented Jul 10, 2019

Sure, done

Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience, LGTM (modulo the minor docs change).

readme.md Outdated Show resolved Hide resolved
Co-Authored-By: Mark Lee <[email protected]>
@malept malept merged commit 434afdb into electron:master Jul 10, 2019
@mvines
Copy link
Contributor Author

mvines commented Jul 10, 2019

Sweet, thanks

@zeke
Copy link
Contributor

zeke commented Jul 10, 2019

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants