Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies : update rust sdk to 0.2.68 #3988

Merged
merged 6 commits into from
Dec 3, 2024
Merged

dependencies : update rust sdk to 0.2.68 #3988

merged 6 commits into from
Dec 3, 2024

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Dec 3, 2024 •
edited
Loading

Content

Update rust sdk to 0.2.68, including new UtdCauses from #3980

Motivation and context

Replaces #3987

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • Changes have been tested on an Android device or Android emulator with API 23
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly define what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • Pull request includes a sign off
  • You've made a self review of your PR

@ganfra ganfra marked this pull request as ready for review December 3, 2024 11:46
@ganfra ganfra requested a review from a team as a code owner December 3, 2024 11:46
@ganfra ganfra requested review from bmarty and removed request for a team December 3, 2024 11:46
@ganfra ganfra added the PR-Dependencies Pull requests that update a dependency file label Dec 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited
Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/odRAjU

@ganfra ganfra added the Z-NextRelease For issues and PRs which should be included in the NextRelease. label Dec 3, 2024
@ganfra ganfra force-pushed the feature/fga/update_rust_sdk_0.2.68 branch from 82f97fe to 894c0f2 Compare December 3, 2024 13:29
@ganfra ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 3, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 3, 2024
BillCarsonFr
BillCarsonFr approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@BillCarsonFr BillCarsonFr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx just a cmment, I hope that we quickly get 4305 merged to use all the new codes.

.../api/src/main/kotlin/io/element/android/libraries/matrix/api/timeline/item/event/UtdCause.kt
* The key was withheld on purpose because your device is insecure and/or the
* sender trust requirement settings are not met for your device.
*/
WithheldUnverifiedOrInsecureDevice,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok but for now WithheldUnverifiedOrInsecureDevice and WithheldBySender will be unused until matrix-org/matrix-rust-sdk#4305 is merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth a comment here? so that we don't wrongly think it is already supported?
Alternative is to remove them for now and do a PR after, as you prefer

Copy link
Member Author

@ganfra ganfra Dec 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add a comment, but this will be merged very soon, right?
Also when merged it won't compile, so to me it's safe to keep like that.

@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.10%. Comparing base (cfb91be) to head (d83bd5b).
Report is 27 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3988   +/-   ##
========================================
  Coverage    83.10%   83.10%           
========================================
  Files         1806     1806           
  Lines        45703    45724   +21     
  Branches      5383     5383           
========================================
+ Hits         37980    38001   +21     
  Misses        5835     5835           
  Partials      1888     1888

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 3, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 3, 2024
@ganfra ganfra enabled auto-merge December 3, 2024 14:26
@ganfra ganfra disabled auto-merge December 3, 2024 14:34
@ganfra ganfra added the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 3, 2024
@github-actions github-actions bot removed the Record-Screenshots Runs the 'Record Screenshots' CI job and adds a commit with any new screenshots found. label Dec 3, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ganfra ganfra enabled auto-merge December 3, 2024 15:24
@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 3, 2024
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 3, 2024
@ganfra ganfra merged commit 01cd76a into develop Dec 3, 2024
30 checks passed
@ganfra ganfra deleted the feature/fga/update_rust_sdk_0.2.68 branch December 3, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillCarsonFr BillCarsonFr BillCarsonFr approved these changes

@bmarty bmarty Awaiting requested review from bmarty bmarty is a code owner automatically assigned from element-hq/element-x-android-reviewers

Assignees
No one assigned
Labels
PR-Dependencies Pull requests that update a dependency file Z-NextRelease For issues and PRs which should be included in the NextRelease.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganfra @BillCarsonFr @ElementBot