Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Confirm your recovery key" doesn't explain you can enter your passphrase #2217

Closed
ara4n opened this issue Dec 8, 2023 · 5 comments
Closed
Assignees
Labels
A-E2EE Encryption O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Dec 8, 2023

Steps to reproduce

  1. Enable key backup
  2. View the "Confirm your recovery key" prompt
Screenshot 2023-12-08 at 18 58 12
  1. Panic vaguely that you don't have a recovery key - you only have a "security passphrase".
  2. Discover that despite it explicitly asking you for a 48 character recovery key, the passphrase works too.

Outcome

What did you expect?

For the prompt to acknowledge that over the years Element/Riot has encouraged users to store/set a "security key", "security passphrase", "recovery key" and "recovery passphrase" - and any of them are valid here.

E.g. "If you don't have a 48 character recovery key, you can also enter a recovery or security passphrase or key." in small print rather than "Enter the 48 character code"

What happened instead?

It sits on a throne of lies.

Your phone model

No response

Operating system version

No response

Application version

451

Homeserver

No response

Will you send logs?

No

@ara4n ara4n added the T-Defect label Dec 8, 2023
@pixlwave pixlwave added A-E2EE Encryption S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Dec 11, 2023
@pixlwave
Copy link
Member

@pmaier1 Assigning this to you as I believe the passphrase wording was omitted intentionally.

@kenrachynski
Copy link

I just got pointed at this issue after having the dialog to correct my recovery key showed up without me doing anything at all.

I suspect this came from TestFlight updating my copy of Element X and this feature is now active. So I didn't even do step 1 of the reproduction; I went straight to step 2 when I opened the app for the first time today.

@pmaier1
Copy link

pmaier1 commented Apr 3, 2024

Agreed. We should provide guidance for legacy terminology (security key) and functionality (passphrase). The passphrase continues to work in EX and we should tell the user.

@americanrefugee can you make a proposal?

@americanrefugee
Copy link

Sure, here is a proposal.. These changes are also relevant to issue 583.

@pmaier1
Copy link

pmaier1 commented Apr 25, 2024

This is done on EIX/EAX, thanks!

@pmaier1 pmaier1 closed this as completed Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-E2EE Encryption O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

5 participants