Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the composer from jumping when in reply to mode and reaching … #2130

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

stefanceriu
Copy link
Member

…the end of the line

Problem:

Simulator.Screen.Recording.-.iPhone.14.-.2023-11-21.at.12.58.55.mp4

@stefanceriu stefanceriu requested a review from a team as a code owner November 21, 2023 11:19
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team November 21, 2023 11:19
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against ea53b48

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (053e134) 71.91% compared to head (ea53b48) 71.90%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2130      +/-   ##
===========================================
- Coverage    71.91%   71.90%   -0.02%     
===========================================
  Files          509      509              
  Lines        34597    34598       +1     
  Branches     16640    16640              
===========================================
- Hits         24882    24878       -4     
- Misses        9099     9104       +5     
  Partials       616      616              
Flag Coverage Δ
unittests 57.16% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu merged commit f7e5dfd into develop Nov 21, 2023
@stefanceriu stefanceriu deleted the stefan/composerReplyLayout branch November 21, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants