Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable carryforward only for ui and unit tests #2132

Closed
wants to merge 2 commits into from

Conversation

stefanceriu
Copy link
Member

Pull Request Checklist

UI changes have been tested with:

  • iPhone and iPad simulators in portrait and landscape orientations.
  • Dark mode enabled and disabled.
  • Various sizes of dynamic type.
  • Voiceover enabled.

Copy link

github-actions bot commented Nov 21, 2023

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against f9d98c9

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f65dfe) 72.00% compared to head (f9d98c9) 64.84%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2132      +/-   ##
===========================================
- Coverage    72.00%   64.84%   -7.17%     
===========================================
  Files          511      511              
  Lines        34721    34721              
  Branches     16673    16673              
===========================================
- Hits         25001    22514    -2487     
- Misses        9105    11669    +2564     
+ Partials       615      538      -77     
Flag Coverage Δ
integrationtests ?
unittests 57.31% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stefanceriu stefanceriu closed this Dec 4, 2023
@stefanceriu stefanceriu deleted the stefan/codecovTweaking branch December 4, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant