Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CONTRIBUTING.md #2135

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Update CONTRIBUTING.md #2135

merged 1 commit into from
Nov 22, 2023

Conversation

pixlwave
Copy link
Member

Small follow-up to #2113 which updates some relevant docs.

@pixlwave pixlwave requested a review from a team as a code owner November 21, 2023 16:45
@pixlwave pixlwave requested review from stefanceriu and removed request for a team November 21, 2023 16:45
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 4294d63

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d03c97a) 72.00% compared to head (4294d63) 71.91%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2135      +/-   ##
===========================================
- Coverage    72.00%   71.91%   -0.09%     
===========================================
  Files          511      511              
  Lines        34722    34722              
  Branches     16673    16673              
===========================================
- Hits         25000    24969      -31     
- Misses        9105     9142      +37     
+ Partials       617      611       -6     
Flag Coverage Δ
unittests 57.32% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit 7c3ee01 into develop Nov 22, 2023
9 checks passed
@pixlwave pixlwave deleted the doug/update-instructions branch November 22, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants