Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a crash when blocking/unblocking a user #2143

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

pixlwave
Copy link
Member

The view state doesn't like mutating an optional when built in release mode. Will take a look at making a minimal reproduction example and filing a bug on the compiler.

Fixes #2140.

The view state doesn't like mutating an optional when built in release mode.
@pixlwave pixlwave requested a review from a team as a code owner November 22, 2023 12:01
@pixlwave pixlwave requested review from Velin92 and removed request for a team November 22, 2023 12:01
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.

Generated by 🚫 Danger Swift against 698d106

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c3ee01) 72.00% compared to head (698d106) 72.01%.
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2143   +/-   ##
========================================
  Coverage    72.00%   72.01%           
========================================
  Files          511      511           
  Lines        34722    34728    +6     
  Branches     16673    16673           
========================================
+ Hits         25001    25008    +7     
  Misses        9105     9105           
+ Partials       616      615    -1     
Flag Coverage Δ
unittests 57.33% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@pixlwave pixlwave merged commit 99f5601 into develop Nov 22, 2023
9 checks passed
@pixlwave pixlwave deleted the doug/fix-block-crash branch November 22, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocking and unblocking a user from a DM crashes the app
2 participants