Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2145 - Hide pin code in setup mode #2146

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fixes #2145 - Hide pin code in setup mode #2146

merged 1 commit into from
Nov 22, 2023

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu requested a review from pixlwave November 22, 2023 12:58
@stefanceriu stefanceriu requested a review from a team as a code owner November 22, 2023 12:58
Copy link

github-actions bot commented Nov 22, 2023

Warnings
⚠️ Please provide a description for this PR.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against df73f43

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Changelog perhaps?

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c3ee01) 72.00% compared to head (3a00b44) 71.91%.
Report is 6 commits behind head on develop.

❗ Current head 3a00b44 differs from pull request most recent head df73f43. Consider uploading reports for the commit df73f43 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2146      +/-   ##
===========================================
- Coverage    72.00%   71.91%   -0.09%     
===========================================
  Files          511      511              
  Lines        34722    34722              
  Branches     16673    16673              
===========================================
- Hits         25001    24972      -29     
- Misses        9105     9137      +32     
+ Partials       616      613       -3     
Flag Coverage Δ
unittests 57.23% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stefanceriu stefanceriu merged commit 9ed35e8 into develop Nov 22, 2023
5 checks passed
@stefanceriu stefanceriu deleted the stefan/2145 branch November 22, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants