Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2147 - Automatically scroll the timeline to the bottom when se… #2149

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

stefanceriu
Copy link
Member

…nding a message

@stefanceriu stefanceriu requested a review from a team as a code owner November 22, 2023 15:11
@stefanceriu stefanceriu requested review from nimau and removed request for a team November 22, 2023 15:11
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7b8f4f8) 71.90% compared to head (47b813a) 71.80%.
Report is 4 commits behind head on develop.

Files Patch % Lines
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2149      +/-   ##
===========================================
- Coverage    71.90%   71.80%   -0.10%     
===========================================
  Files          511      511              
  Lines        34731    34733       +2     
  Branches     16677    16677              
===========================================
- Hits         24972    24940      -32     
- Misses        9146     9177      +31     
- Partials       613      616       +3     
Flag Coverage Δ
unittests 57.10% <0.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nimau nimau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanceriu stefanceriu merged commit 0dbcece into develop Nov 22, 2023
@stefanceriu stefanceriu deleted the stefan/2147 branch November 22, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants