-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2414 - Move member loading to the room member detail screen, a… #2425
Conversation
Generated by 🚫 Danger Swift against 67c0abe |
ElementX/Sources/Screens/RoomMemberDetailsScreen/View/RoomMemberDetailsScreen.swift
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just some testing suggestions mostly. Can you also upload a video of the new behaviour for a big room and a small room?
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #2425 +/- ##
===========================================
- Coverage 72.99% 72.74% -0.26%
===========================================
Files 523 523
Lines 36191 36238 +47
Branches 17413 17419 +6
===========================================
- Hits 26417 26360 -57
- Misses 9135 9238 +103
- Partials 639 640 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…void blocking the whole application
e2bc599
to
67c0abe
Compare
|
…void blocking the whole application
Simulator.Screen.Recording.-.iPhone.15.-.2024-02-07.at.08.40.06.mp4