Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer joined and active member count from the member list, default t… #2431

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Infer joined and active member count from the member list, default t… #2431

merged 2 commits into from
Feb 7, 2024

Conversation

stefanceriu
Copy link
Member

…he members to all mock members

@stefanceriu stefanceriu requested a review from a team as a code owner February 7, 2024 13:23
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team February 7, 2024 13:23
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024 •
edited
Loading

Warnings
⚠️ Please add a changelog.
⚠️ Some of the commits are missing ticket numbers. Please consider squashing all commits that don't have a tracking number.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 3daae64

pixlwave
pixlwave approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tidy-up here 👍

ElementX/Sources/Mocks/RoomMemberProxyMock.swift Show resolved Hide resolved
UnitTests/__Snapshots__/PreviewTests/test_roomDetailsScreen.DM-Room.png Outdated Show resolved Hide resolved
ElementX/Sources/Mocks/RoomProxyMock.swift Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
4.7% Duplication on New Code

See analysis details on SonarCloud

@stefanceriu stefanceriu changed the title Infert joined and active member count from the member list, default t… Infer joined and active member count from the member list, default t… Feb 7, 2024
@stefanceriu stefanceriu merged commit c320152 into develop Feb 7, 2024
4 of 5 checks passed
@stefanceriu stefanceriu deleted the stefan/memberMocksCleanup branch February 7, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave