Fix a potential race condition when redacting a message. #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move it into its own struct. - Use an item, not an ID so it doesn't randomly change. - Move permissions into the room screen view model.
Just like we do when fetching the item in the actions menu.
Generated by 🚫 Danger Swift against d0de242 |
Velin92
approved these changes
Jul 18, 2024
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3061 +/- ##
===========================================
- Coverage 77.84% 77.33% -0.51%
===========================================
Files 694 699 +5
Lines 54099 54396 +297
===========================================
- Hits 42112 42066 -46
- Misses 11987 12330 +343
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix is in the second commit of the PR (and matches how we fetch the item to put into the action menu). The first commit is after discussing and discovering with @stefanceriu that the menu was updating as the item updated, but wasn't updating its ID. We decided it would be better to not automatically update the menu if the item changes, the user will be able to see that the message wasn't sent when long pressing it.