Pinned Items Banner UI #3072
Merged
Pinned Items Banner UI #3072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Velin92
added
the
pr-wip
Generated by 🚫 Danger Swift against 026bbec |
Velin92
force-pushed
the
mauroromito/pinned_items_banner
branch
from
0018586 to
e95ed21
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3072 +/- ##
===========================================
+ Coverage 77.97% 78.05% +0.07%
===========================================
Files 701 703 +2
Lines 54209 54325 +116
===========================================
+ Hits 42270 42403 +133
+ Misses 11939 11922 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pixlwave
approved these changes
Jul 22, 2024
ElementX/Sources/Screens/RoomScreen/View/PinnedItemsBanner/PinnedItemsBannerView.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/PinnedItemsBanner/PinnedItemsBannerView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/PinnedItemsBanner/PinnedItemsIndicatorView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/PinnedItemsBanner/PinnedItemsBannerView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomScreen/View/PinnedItemsBanner/PinnedItemsBannerView.swift
Outdated
Show resolved
Hide resolved
Velin92
force-pushed
the
mauroromito/pinned_items_banner
branch
from
ef60d4d to
9bd6b40
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the UI for the banner, without any logic for now.