Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image magick replacement + app variants #3691

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Image magick replacement + app variants #3691

merged 2 commits into from
Jan 21, 2025

Conversation

stefanceriu
Copy link
Member

  • setup an app variants folder and move the nightly and alpha build configs to it
  • replace ImageMagick with a custom tool written in swift

@stefanceriu stefanceriu requested a review from pixlwave January 21, 2025 11:33
@stefanceriu stefanceriu requested a review from a team as a code owner January 21, 2025 11:33
@stefanceriu stefanceriu added the pr-build for changes related to build, tools, CI/CD label Jan 21, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 21, 2025 •
edited
Loading

Warnings
⚠️ You seem to have made changes to some resource images. Please consider using an SVG or PDF.

Generated by 🚫 Danger Swift against 296cabf

@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.66%. Comparing base (8577f53) to head (296cabf).
Report is 3 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3691   +/-   ##
========================================
  Coverage    78.66%   78.66%           
========================================
  Files          792      792           
  Lines        67700    67700           
========================================
+ Hits         53253    53254    +1     
+ Misses       14447    14446    -1
Flag Coverage Δ
unittests 70.18% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pixlwave
pixlwave approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, might be worth running the PR build on this to double check the output?

Tools/Sources/AppIconBanner.swift Outdated Show resolved Hide resolved
Tools/Sources/Tools.swift Show resolved Hide resolved
fastlane/Fastfile Outdated Show resolved Hide resolved
fastlane/Fastfile Outdated Show resolved Hide resolved
@stefanceriu stefanceriu added the Trigger-PR-Build Uses to trigger alpha builds for PRs label Jan 21, 2025
@stefanceriu stefanceriu force-pushed the stefan/imageMagickReplacement branch from 2c96048 to 296cabf Compare January 21, 2025 14:25
@stefanceriu stefanceriu merged commit 55e399a into develop Jan 21, 2025
4 of 5 checks passed
@stefanceriu stefanceriu deleted the stefan/imageMagickReplacement branch January 21, 2025 14:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
pr-build for changes related to build, tools, CI/CD Trigger-PR-Build Uses to trigger alpha builds for PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave