Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused/redundant assets. #3702

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Remove unused/redundant assets. #3702

merged 2 commits into from
Jan 27, 2025

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jan 24, 2025

This PR does the following:

  • Remove old image assets that are no longer used in the app.
  • Remove an old brand-color asset that was only used in the Migration/Waitlist screens and is no longer necessary (I think theres a colour token for this in one way or another now).
  • Remove a grabber colour which after checking the component in Compound I saw was simply a copy of the system tertiary colour.

@pixlwave pixlwave requested a review from a team as a code owner January 24, 2025 13:04
@pixlwave pixlwave requested review from Velin92 and removed request for a team January 24, 2025 13:04
Copy link

github-actions bot commented Jan 24, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against fe5d952

@pixlwave pixlwave added the pr-misc for other changes label Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.70%. Comparing base (a70189d) to head (fe5d952).
Report is 4 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...mScreen/ComposerToolbar/View/MessageComposer.swift 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3702      +/-   ##
===========================================
- Coverage    78.72%   78.70%   -0.03%     
===========================================
  Files          792      792              
  Lines        67839    67826      -13     
===========================================
- Hits         53409    53381      -28     
- Misses       14430    14445      +15     
Flag Coverage Δ
unittests 70.22% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave merged commit b477a32 into develop Jan 27, 2025
15 checks passed
@pixlwave pixlwave deleted the doug/tidy-assets branch January 27, 2025 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants