Bump the RustSDK to 25.01.27, adopt the new emoji boosting API. #3708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger Swift against 649f4af |
pixlwave
reviewed
Jan 27, 2025
ElementX/Sources/Screens/Timeline/View/TimelineItemViews/FormattedBodyText.swift
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3708 +/- ##
===========================================
- Coverage 78.83% 78.78% -0.05%
===========================================
Files 794 793 -1
Lines 68156 68142 -14
===========================================
- Hits 53730 53685 -45
- Misses 14426 14457 +31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pixlwave
reviewed
Jan 27, 2025
| .roomKeyRecipientStrategy(strategy: .deviceBasedStrategy(onlyAllowTrustedDevices: false, errorOnVerifiedUserProblem: true)) | ||
| .roomKeyRecipientStrategy(strategy: .errorOnVerifiedUserProblem) |
There was a problem hiding this comment.
Changed based on the following:
@richvdh does this look correct?
There was a problem hiding this comment.
can't vouch for the syntax, but the general idea looks right
pixlwave
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.