Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not handle offline mode yet #3715

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Jan 29, 2025

Requires matrix-org/matrix-rust-sdk#4592 to be merged first

@Velin92 Velin92 requested a review from a team as a code owner January 29, 2025 14:44
@Velin92 Velin92 requested review from pixlwave and removed request for a team January 29, 2025 14:44
@Velin92 Velin92 added the pr-api for an api break label Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.75%. Comparing base (63b819e) to head (bd7336e).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3715      +/-   ##
===========================================
+ Coverage    78.71%   78.75%   +0.04%     
===========================================
  Files          792      792              
  Lines        68204    68204              
===========================================
+ Hits         53688    53716      +28     
+ Misses       14516    14488      -28     
Flag Coverage Δ
unittests 70.34% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ElementX/Sources/Mocks/Generated/SDKGeneratedMocks.swift Outdated Show resolved Hide resolved
@Velin92 Velin92 force-pushed the mauroromito/offline_mode_provvisory_handling branch from 26bff1c to bd7336e Compare January 31, 2025 11:05
@Velin92 Velin92 enabled auto-merge (squash) January 31, 2025 11:05
@Velin92 Velin92 merged commit d5fb72c into develop Jan 31, 2025
8 checks passed
@Velin92 Velin92 deleted the mauroromito/offline_mode_provvisory_handling branch January 31, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-api for an api break
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants