Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix the every flakey app lock setup test #3716

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Attempt to fix the every flakey app lock setup test #3716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion UITests/Sources/AppLockSetupUITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,17 @@ class AppLockSetupUITests: XCTestCase {

enterPIN()

// This test has been especially flakey. We noticed that confirming the PIN will
// automatically hide the keyboard which makes the whole screen shift down while
// attempting to press the allow button. We also see an `App animations complete
// notification not received, will attempt to continue.` warning which seems to
// point to the same issue.
try await Task.sleep(for: .seconds(1.0))

// Setup biometrics screen.
try await app.assertScreenshot(.appLockSetupFlow, step: Step.setupBiometrics)

app.buttons[A11yIdentifiers.appLockSetupBiometricsScreen.allow].tap()
app.buttons[A11yIdentifiers.appLockSetupBiometricsScreen.allow].tapCenter()

// Settings screen.
try await app.assertScreenshot(.appLockSetupFlow, step: Step.settings)
Expand Down
Loading