Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable continueAfterFailure for the AppLock UI tests #3720

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Disable continueAfterFailure for the AppLock UI tests #3720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions UITests/Sources/AppLockSetupUITests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ import XCTest
class AppLockSetupUITests: XCTestCase {
var app: XCUIApplication!

override func setUpWithError() throws {
try super.setUpWithError()
continueAfterFailure = false
}

@MainActor enum Step {
static let createPIN = 0
static let confirmPIN = 1
Expand Down
5 changes: 5 additions & 0 deletions UITests/Sources/AppLockUITests.swift
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need it on these?

Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ class AppLockUITests: XCTestCase {
static let unlocked = 99
}

override func setUpWithError() throws {
try super.setUpWithError()
continueAfterFailure = false
}

func testFlowEnabled() async throws {
// Given an app with screen lock enabled.
let client = try UITestsSignalling.Client(mode: .tests)
Expand Down
Loading