-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure multiple mandatory verification flows can be ran consecutively (e.g. following encryption resets) #3722
Conversation
stefanceriu
commented
Jan 31, 2025
•
edited
Loading
edited
- running multiple remote resets would find the onboarding flow coordinator in a finished state and prevent showing the mandatory verification again. Fixed that by transitioning from finished to initial automatically
- added onboarding flow coordinator state machine logs
- removed security state deduplication and added extra main queue dispatches
Generated by 🚫 Danger Swift against bfdf2a9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I think it hides the button on the wrong screen.
...tX/Sources/Screens/Onboarding/SessionVerificationScreen/View/SessionVerificationScreen.swift
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #3722 +/- ##
===========================================
+ Coverage 78.72% 78.78% +0.06%
===========================================
Files 792 792
Lines 68204 68214 +10
===========================================
+ Hits 53691 53740 +49
+ Misses 14513 14474 -39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… (e.g. following encryption resets)
…d and waiting for the security state publisher
3360e17
to
bfdf2a9
Compare
|