Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure multiple mandatory verification flows can be ran consecutively (e.g. following encryption resets) #3722

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Jan 31, 2025

  • running multiple remote resets would find the onboarding flow coordinator in a finished state and prevent showing the mandatory verification again. Fixed that by transitioning from finished to initial automatically
  • added onboarding flow coordinator state machine logs
  • removed security state deduplication and added extra main queue dispatches

@stefanceriu stefanceriu added the pr-bugfix for bug fix label Jan 31, 2025
@stefanceriu stefanceriu requested a review from a team as a code owner January 31, 2025 14:42
@stefanceriu stefanceriu requested review from Velin92 and pixlwave and removed request for a team and Velin92 January 31, 2025 14:42
Copy link

github-actions bot commented Jan 31, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against bfdf2a9

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I think it hides the button on the wrong screen.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes missing coverage. Please review.

Project coverage is 78.78%. Comparing base (4856ffd) to head (bfdf2a9).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/FlowCoordinators/OnboardingFlowCoordinator.swift 68.75% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3722      +/-   ##
===========================================
+ Coverage    78.72%   78.78%   +0.06%     
===========================================
  Files          792      792              
  Lines        68204    68214      +10     
===========================================
+ Hits         53691    53740      +49     
+ Misses       14513    14474      -39     
Flag Coverage Δ
unittests 70.45% <73.68%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu requested a review from pixlwave January 31, 2025 15:08
@stefanceriu stefanceriu force-pushed the stefan/onboardingFlowFixes branch from 3360e17 to bfdf2a9 Compare January 31, 2025 15:31
@stefanceriu stefanceriu merged commit 9706985 into develop Jan 31, 2025
5 checks passed
@stefanceriu stefanceriu deleted the stefan/onboardingFlowFixes branch January 31, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants