Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakey room member details screen snapshot test #3726

Merged

Conversation

stefanceriu
Copy link
Member

  • needs to wait for the call button to appear i.e. dmRoomID

- needs to wait for the call button to appear i.e. dmRoomID
@stefanceriu stefanceriu requested a review from a team as a code owner February 1, 2025 12:06
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team February 1, 2025 12:06
Copy link

github-actions bot commented Feb 1, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against a8905b0

Copy link

sonarqubecloud bot commented Feb 1, 2025

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.36%. Comparing base (6cd583d) to head (a8905b0).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3726      +/-   ##
===========================================
+ Coverage    78.34%   78.36%   +0.02%     
===========================================
  Files          794      794              
  Lines        68594    68594              
===========================================
+ Hits         53737    53754      +17     
+ Misses       14857    14840      -17     
Flag Coverage Δ
unittests 70.35% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stefanceriu stefanceriu added the pr-misc for other changes label Feb 3, 2025
@stefanceriu stefanceriu merged commit 9df5a8f into develop Feb 3, 2025
13 of 15 checks passed
@stefanceriu stefanceriu deleted the stefan/flakeyRoomMemberDetailsScreenSnapshotTest branch February 3, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants