Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoomTimeline… refactor (drop the Room). #3728

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Feb 3, 2025

This PR refactors RoomTimelineProvider, RoomTimelineController and RoomTimelineControllerFactory to drop the Room for more consistency with #3157.

Additionally it adds a timeline controller factory to TimelineViewModel in preparation for swiping between media.

@pixlwave pixlwave requested a review from a team as a code owner February 3, 2025 13:00
@pixlwave pixlwave requested review from stefanceriu and removed request for a team February 3, 2025 13:00
@pixlwave pixlwave added the pr-misc for other changes label Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 855ea21

Copy link

sonarqubecloud bot commented Feb 3, 2025

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 57.30337% with 76 lines in your changes missing coverage. Please review.

Project coverage is 77.60%. Comparing base (9df5a8f) to head (855ea21).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...TimelineController/TimelineControllerFactory.swift 0.00% 33 Missing ⚠️
...rdinators/MediaEventsTimelineFlowCoordinator.swift 0.00% 13 Missing ⚠️
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 53.33% 7 Missing ⚠️
...dinators/PinnedEventsTimelineFlowCoordinator.swift 0.00% 6 Missing ⚠️
...meline/TimelineController/TimelineController.swift 0.00% 5 Missing ⚠️
...eScreen/MediaEventsTimelineScreenCoordinator.swift 0.00% 4 Missing ⚠️
...Screen/PinnedEventsTimelineScreenCoordinator.swift 0.00% 2 Missing ⚠️
.../Screens/Timeline/TimelineInteractionHandler.swift 60.00% 2 Missing ⚠️
ElementX/Sources/Application/AppCoordinator.swift 0.00% 1 Missing ⚠️
...lePreviewScreen/TimelineMediaPreviewModifier.swift 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3728      +/-   ##
===========================================
- Coverage    78.34%   77.60%   -0.74%     
===========================================
  Files          794      797       +3     
  Lines        68594    69273     +679     
===========================================
+ Hits         53737    53759      +22     
- Misses       14857    15514     +657     
Flag Coverage Δ
unittests 70.36% <57.30%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@pixlwave pixlwave merged commit d195e60 into develop Feb 3, 2025
15 checks passed
@pixlwave pixlwave deleted the doug/room-timeline-refactor branch February 3, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants