-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RoomTimeline… refactor (drop the Room
).
#3728
Conversation
In preparation for building a timeline to swipe through media in QuickLook.
Generated by 🚫 Danger Swift against 855ea21 |
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3728 +/- ##
===========================================
- Coverage 78.34% 77.60% -0.74%
===========================================
Files 794 797 +3
Lines 68594 69273 +679
===========================================
+ Hits 53737 53759 +22
- Misses 14857 15514 +657
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
This PR refactors
RoomTimelineProvider
,RoomTimelineController
andRoomTimelineControllerFactory
to drop theRoom
for more consistency with #3157.Additionally it adds a timeline controller factory to
TimelineViewModel
in preparation for swiping between media.