-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an alert before creating a new DM #3730
Conversation
Element CI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
240f853
to
988a5dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
ElementX/Sources/Screens/RoomMemberDetailsScreen/RoomMemberDetailsScreenModels.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomMemberDetailsScreen/RoomMemberDetailsScreenViewModel.swift
Show resolved
Hide resolved
ElementX/Sources/Screens/UserProfileScreen/UserProfileScreenModels.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/RoomMemberDetailsScreen/RoomMemberDetailsScreenViewModel.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/UserProfileScreen/UserProfileScreenViewModel.swift
Outdated
Show resolved
Hide resolved
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## develop #3730 +/- ##
===========================================
- Coverage 77.63% 77.54% -0.09%
===========================================
Files 797 797
Lines 69273 69319 +46
===========================================
- Hits 53780 53756 -24
- Misses 15493 15563 +70
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fixes #3729