Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an alert before creating a new DM #3730

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Feb 3, 2025

fixes #3729

@Velin92 Velin92 requested a review from a team as a code owner February 3, 2025 14:51
@Velin92 Velin92 requested review from pixlwave and removed request for a team February 3, 2025 14:51
@CLAassistant
Copy link

CLAassistant commented Feb 3, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Element CI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Velin92 Velin92 added the pr-change for updates to an existing feature label Feb 3, 2025
@Velin92 Velin92 force-pushed the mauroromito/dm_confirmation_alert branch from 240f853 to 988a5dc Compare February 3, 2025 14:58
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
34.9% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.

Project coverage is 77.54%. Comparing base (d195e60) to head (3028eca).
Report is 3 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...tailsScreen/RoomMemberDetailsScreenViewModel.swift 0.00% 31 Missing ⚠️
...UserProfileScreen/UserProfileScreenViewModel.swift 0.00% 25 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3730      +/-   ##
===========================================
- Coverage    77.63%   77.54%   -0.09%     
===========================================
  Files          797      797              
  Lines        69273    69319      +46     
===========================================
- Hits         53780    53756      -24     
- Misses       15493    15563      +70     
Flag Coverage Δ
unittests 70.27% <0.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Velin92 Velin92 merged commit 10d3925 into develop Feb 3, 2025
11 of 13 checks passed
@Velin92 Velin92 deleted the mauroromito/dm_confirmation_alert branch February 3, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Confirmation alert when creating a new DM
3 participants