-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Rust timeline identifiers into our own. #3731
Conversation
4b48291
to
e4f1329
Compare
Generated by 🚫 Danger Swift against e4f1329 |
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #3731 +/- ##
===========================================
- Coverage 77.58% 77.53% -0.05%
===========================================
Files 797 797
Lines 69319 69329 +10
===========================================
- Hits 53782 53757 -25
- Misses 15537 15572 +35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couldn't we use a typealias of String with some methods on top, instead of defining a struct with a single value?
In preparation for swiping media in the room screen, this PR replaces all the uses of Rust's
EventOrTransactionId
andTimelineUniqueId
with our own local versions as it seems silly to keep importing the SDK into UI layers just to identify things.Broken into 2 commits, one for each refactor so it should be easier to review.