Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knocking polishing part 1 #3732

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Knocking polishing part 1 #3732

merged 1 commit into from
Feb 4, 2025

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Feb 3, 2025

  • using joined members count for the preview
  • listen to the membership state change when you are in the knocked state

@Velin92 Velin92 requested a review from a team as a code owner February 3, 2025 17:27
@Velin92 Velin92 requested review from stefanceriu and removed request for a team February 3, 2025 17:28
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Element CI seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Velin92 Velin92 requested a review from pixlwave February 3, 2025 17:28
@Velin92 Velin92 added the pr-bugfix for bug fix label Feb 3, 2025
Copy link

sonarqubecloud bot commented Feb 3, 2025

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.58%. Comparing base (10d3925) to head (e90757a).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...reens/JoinRoomScreen/JoinRoomScreenViewModel.swift 80.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3732      +/-   ##
===========================================
- Coverage    77.58%   77.58%   -0.01%     
===========================================
  Files          797      797              
  Lines        69319    69333      +14     
===========================================
+ Hits         53782    53791       +9     
- Misses       15537    15542       +5     
Flag Coverage Δ
unittests 70.35% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Velin92 Velin92 merged commit 5d785b3 into develop Feb 4, 2025
14 of 15 checks passed
@Velin92 Velin92 deleted the mauroromito/knocking_bugfixes branch February 4, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants