Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the SDK to 25.02.04 #3737

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Feb 4, 2025

Includes some APIs required for the next knocking polishing PR

@Velin92 Velin92 requested a review from a team as a code owner February 4, 2025 16:21
@Velin92 Velin92 requested review from pixlwave and removed request for a team February 4, 2025 16:21
@Velin92 Velin92 enabled auto-merge (squash) February 4, 2025 16:23
@Velin92 Velin92 added the pr-misc for other changes label Feb 4, 2025
@stefanceriu
Copy link
Member

Doesn't this need to adopt Jorge's changes so we don't break the Auth service matrix-org/matrix-rust-sdk#4607 ?

Copy link

sonarqubecloud bot commented Feb 4, 2025

@Velin92 Velin92 merged commit 6c190cf into develop Feb 4, 2025
8 checks passed
@Velin92 Velin92 deleted the mauroromito/update_sdk_for_knocking branch February 4, 2025 16:57
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.51%. Comparing base (f0b8775) to head (e6a1d0c).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ervices/Authentication/AuthenticationService.swift 16.66% 5 Missing ⚠️
...urces/Screens/CreateRoom/CreateRoomViewModel.swift 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3737      +/-   ##
===========================================
+ Coverage    77.48%   77.51%   +0.03%     
===========================================
  Files          797      797              
  Lines        69389    69389              
===========================================
+ Hits         53767    53790      +23     
+ Misses       15622    15599      -23     
Flag Coverage Δ
unittests 70.27% <11.11%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Velin92 added a commit that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants