Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Knocking feature polishing part 2 #3738

Merged
merged 6 commits into from
Feb 5, 2025
Merged

Knocking feature polishing part 2 #3738

merged 6 commits into from
Feb 5, 2025

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Feb 4, 2025 •
edited
Loading

  • Added an error state when joining fails due to forbidden access
  • Improved the presentation of invites for DMs
  • Forget action for banned room previews implemented

@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Feb 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against cb8b1ec

@Velin92 Velin92 force-pushed the mauroromito/knock_polishing_part_2 branch from 4f37cae to 205129f Compare February 4, 2025 17:30
@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
925 1 924 0
View the top 1 failed tests by shortest run time 
MediaUploadPreviewScreenViewModelTests testVideoUploadWithCaption()
Stack Traces | 12s run time 
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Other/Extensions/XCTestCase.swift:43)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@Velin92 Velin92 marked this pull request as ready for review February 4, 2025 19:58
@Velin92 Velin92 requested a review from a team as a code owner February 4, 2025 19:58
@Velin92 Velin92 requested review from stefanceriu and removed request for a team February 4, 2025 19:58
@Velin92 Velin92 requested a review from stefanceriu February 5, 2025 13:17
@Velin92 Velin92 force-pushed the mauroromito/knock_polishing_part_2 branch from 4100454 to f57428c Compare February 5, 2025 13:20
stefanceriu
stefanceriu approved these changes Feb 5, 2025
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, 🚀 it!

@Velin92 Velin92 force-pushed the mauroromito/knock_polishing_part_2 branch from f57428c to cb8b1ec Compare February 5, 2025 13:48
@Velin92 Velin92 merged commit 3839025 into develop Feb 5, 2025
2 checks passed
@Velin92 Velin92 deleted the mauroromito/knock_polishing_part_2 branch February 5, 2025 13:48
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Velin92 @stefanceriu