Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert unsuccessful UI test stability tweaks #3740

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu requested a review from a team as a code owner February 5, 2025 08:46
@stefanceriu stefanceriu requested review from Velin92 and removed request for a team February 5, 2025 08:46
Copy link

github-actions bot commented Feb 5, 2025

Warnings
⚠️ Please provide a description for this PR.

Generated by 🚫 Danger Swift against cd375d4

Copy link

sonarqubecloud bot commented Feb 5, 2025

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.65%. Comparing base (6c190cf) to head (cd375d4).
Report is 2 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3740   +/-   ##
========================================
  Coverage    78.65%   78.65%           
========================================
  Files          791      791           
  Lines        68430    68430           
========================================
+ Hits         53821    53822    +1     
+ Misses       14609    14608    -1     
Flag Coverage Δ
unittests 70.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Velin92 Velin92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Velin92 Velin92 added the pr-misc for other changes label Feb 5, 2025
@stefanceriu stefanceriu merged commit 42257a1 into develop Feb 5, 2025
14 of 15 checks passed
@stefanceriu stefanceriu deleted the stefan/uiTests branch February 5, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-misc for other changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants