Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some concurrency warnings, update missed licence headers. #3741

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Fix some concurrency warnings, update missed licence headers. #3741

merged 4 commits into from
Feb 6, 2025

Conversation

stefanceriu
Copy link
Member

No description provided.

@stefanceriu stefanceriu requested a review from a team as a code owner February 5, 2025 09:44
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team February 5, 2025 09:44
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 5, 2025 •
edited
Loading

Warnings
⚠️ Please provide a description for this PR.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 1f24bf0

@codecov Codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
925 1 924 0
View the full list of 1 ❄️ flaky tests 
MediaUploadPreviewScreenViewModelTests testVideoUploadWithoutCaption()

Flake rate in main: 10.29% (Passed 61 times, Failed 7 times)

Stack Traces | 12.7s run time 
Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "Awaiting publisher". (.../Other/Extensions/XCTestCase.swift:43)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

pixlwave
pixlwave reviewed Feb 5, 2025
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, except for that assumeIsolated.

ElementX/Sources/Application/AppCoordinatorProtocol.swift Outdated Show resolved Hide resolved
ElementX/Sources/Services/Timeline/TimelineController/TimelineController.swift Outdated Show resolved Hide resolved
@stefanceriu stefanceriu added the pr-misc for other changes label Feb 5, 2025
@stefanceriu stefanceriu enabled auto-merge (squash) February 5, 2025 16:01
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@stefanceriu stefanceriu requested a review from pixlwave February 6, 2025 07:05
@stefanceriu stefanceriu disabled auto-merge February 6, 2025 09:35
@stefanceriu stefanceriu merged commit 922ebf4 into develop Feb 6, 2025
8 checks passed
@stefanceriu stefanceriu deleted the stefan/variousTweaks branch February 6, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
pr-misc for other changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanceriu @pixlwave