Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Bottom Sheet message string #3743

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Feb 5, 2025

The display name and the id pair is now localised with its own string that is reusable, and we use it when the display name is available, otherwise we just replace it with the user id.

@Velin92 Velin92 added the pr-change for updates to an existing feature label Feb 5, 2025
@Velin92 Velin92 requested a review from a team as a code owner February 5, 2025 14:10
@Velin92 Velin92 requested review from stefanceriu and removed request for a team February 5, 2025 14:10
Copy link

github-actions bot commented Feb 5, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against c4b7328

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.64%. Comparing base (2515cde) to head (c4b7328).
Report is 3 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rtChatScreen/View/SendInviteConfirmationView.swift 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3743   +/-   ##
========================================
  Coverage    78.64%   78.64%           
========================================
  Files          793      793           
  Lines        68919    68921    +2     
========================================
+ Hits         54203    54205    +2     
  Misses       14716    14716           
Flag Coverage Δ
unittests 70.29% <75.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I'm sorry, I completely missed this pr 😞

@Velin92 Velin92 force-pushed the mauroromito/updated_string branch from 4671a49 to c4b7328 Compare February 7, 2025 09:08
@Velin92 Velin92 merged commit b9e6a33 into develop Feb 7, 2025
5 checks passed
@Velin92 Velin92 deleted the mauroromito/updated_string branch February 7, 2025 09:08
Copy link

sonarqubecloud bot commented Feb 7, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants