Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the banned room proxy #3744

Merged
merged 5 commits into from
Feb 6, 2025
Merged

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Feb 5, 2025

  • This PR updates the SDK to allow a banned room proxy to be generated from the room list item
  • It allows to have forget be used specifically only for banned rooms
  • It also includes an alert to retry loading the room in case it fails for a connection issue

and a way to have a consistent loading + a retry alert
@Velin92 Velin92 requested a review from a team as a code owner February 5, 2025 15:55
@Velin92 Velin92 requested review from pixlwave and removed request for a team February 5, 2025 15:55
Copy link

github-actions bot commented Feb 5, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 5b7ac8d

@Velin92 Velin92 added the pr-wip for anything that isn't ready to ship and will be enabled at a later date label Feb 5, 2025
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.55%. Comparing base (3839025) to head (5b7ac8d).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...reens/JoinRoomScreen/JoinRoomScreenViewModel.swift 57.89% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3744      +/-   ##
===========================================
- Coverage    78.65%   78.55%   -0.10%     
===========================================
  Files          793      793              
  Lines        68877    68892      +15     
===========================================
- Hits         54172    54119      -53     
- Misses       14705    14773      +68     
Flag Coverage Δ
unittests 70.25% <61.90%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Feb 5, 2025

Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Velin92 Velin92 merged commit f86a5a2 into develop Feb 6, 2025
13 checks passed
@Velin92 Velin92 deleted the mauroromito/knock_polish_part_3 branch February 6, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-wip for anything that isn't ready to ship and will be enabled at a later date
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants