Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async load room preview #3747

Closed
wants to merge 2 commits into from
Closed

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Feb 6, 2025

This creates a smoother experience when opening knocked and invited rooms

@Velin92 Velin92 requested a review from a team as a code owner February 6, 2025 13:43
@Velin92 Velin92 requested review from stefanceriu and removed request for a team February 6, 2025 13:43
@Velin92 Velin92 added the pr-bugfix for bug fix label Feb 6, 2025
Copy link

sonarqubecloud bot commented Feb 6, 2025

Copy link

codecov bot commented Feb 6, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
926 2 924 0
View the top 2 failed tests by shortest run time
RoomNotificationSettingsScreenViewModelTests testSetCustomMode()
Stack Traces | 1.08s run time
XCTAssertEqual failed: ("Optional(ElementX.RoomNotificationModeProxy.mute)") is not equal to ("Optional(ElementX.RoomNotificationModeProxy.mentionsAndKeywordsOnly)") (UnitTests/Sources/RoomNotificationSettingsScreenViewModelTests.swift:231)
PreviewTests test_joinRoomScreen()
Stack Traces | 5.9s run time
failed - Snapshot "Invited" does not match reference.

@−
"file:.../__Snapshots__/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Invited.png"
@+
"file:.../tmp/PreviewTests/test_joinRoomScreen-iPhone-16-en-GB.Invited.png"

To configure output for a custom diff tool, use 'withSnapshotTesting'. For example:

    withSnapshotTesting(diffTool: .ksdiff) {
      // ...
    }

The percentage of pixels that match 0.9230957 is less than required 1.0
The lowest perceptual color precision 0.18624997 is less than required 0.98 (PreviewTests/Sources/PreviewTests.swift:85)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@Velin92 Velin92 closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant