Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a delayed loading when opening a room #3748

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

Velin92
Copy link
Member

@Velin92 Velin92 commented Feb 6, 2025

While this won't even appear for joined rooms, this will help greatly for invited and knocked rooms which require the preview API to load first

@Velin92 Velin92 requested a review from a team as a code owner February 6, 2025 14:40
@Velin92 Velin92 requested review from pixlwave and removed request for a team February 6, 2025 14:40
@Velin92 Velin92 added the pr-change for updates to an existing feature label Feb 6, 2025
@Velin92 Velin92 requested a review from stefanceriu February 6, 2025 14:52
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.49%. Comparing base (b900eec) to head (e0df009).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3748   +/-   ##
========================================
  Coverage    78.48%   78.49%           
========================================
  Files          793      793           
  Lines        68906    68919   +13     
========================================
+ Hits         54081    54096   +15     
+ Misses       14825    14823    -2     
Flag Coverage Δ
unittests 70.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits otherwise looks good to me 👍

@Velin92 Velin92 merged commit 7560f2c into develop Feb 6, 2025
5 checks passed
@Velin92 Velin92 deleted the mauroromito/add_a_spinner_when_opening_a_room branch February 6, 2025 16:55
Copy link

sonarqubecloud bot commented Feb 6, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-change for updates to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants