Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug where the preview controller breaks when swiping quickly. #3750

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Feb 6, 2025

This is clearly going to break at some point, but for now, it's a fix 🙈

The updated solution uses recursion, it could still break but it's likely at that point so will the navbar and toolbar.

@pixlwave pixlwave requested a review from a team as a code owner February 6, 2025 18:12
@pixlwave pixlwave requested review from stefanceriu and removed request for a team February 6, 2025 18:12
Copy link

github-actions bot commented Feb 6, 2025

Warnings
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 8d79264

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 78.57%. Comparing base (7560f2c) to head (8d79264).
Report is 8 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...ewScreen/View/TimelineMediaPreviewController.swift 0.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3750      +/-   ##
===========================================
- Coverage    78.57%   78.57%   -0.01%     
===========================================
  Files          793      793              
  Lines        68919    68979      +60     
===========================================
+ Hits         54155    54199      +44     
- Misses       14764    14780      +16     
Flag Coverage Δ
unittests 70.32% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pixlwave pixlwave added the pr-bugfix for bug fix label Feb 7, 2025
@pixlwave pixlwave force-pushed the doug/media-preview-swiping branch from f7e9e60 to 8d79264 Compare February 7, 2025 10:18
Copy link

sonarqubecloud bot commented Feb 7, 2025

@pixlwave pixlwave merged commit b284aa8 into develop Feb 7, 2025
13 checks passed
@pixlwave pixlwave deleted the doug/media-preview-swiping branch February 7, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-bugfix for bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants