Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for initiating and responding to user verification requests #3759

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Feb 7, 2025

Fixes #3753:

  • expands the existing session verification screen to support user verification as well
  • consolidates localizables and layouts between the two
  • updates all snapshots

Does not include:

  • silencing that notification
  • automatically updating the verification states
Screen.Recording.2025-02-07.at.16.36.40.mov

@stefanceriu stefanceriu added the pr-feature for a new feature label Feb 7, 2025
@stefanceriu stefanceriu requested a review from a team as a code owner February 7, 2025 14:46
@stefanceriu stefanceriu requested review from pixlwave and removed request for a team February 7, 2025 14:46
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 74.48560% with 62 lines in your changes missing coverage. Please review.

Project coverage is 78.58%. Comparing base (22d0fae) to head (6b42c66).
Report is 1 commits behind head on develop.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../FlowCoordinators/UserSessionFlowCoordinator.swift 5.55% 17 Missing ⚠️
...nScreen/SessionVerificationScreenCoordinator.swift 0.00% 11 Missing ⚠️
...ionScreen/SessionVerificationScreenViewModel.swift 81.81% 6 Missing ⚠️
...Sources/FlowCoordinators/RoomFlowCoordinator.swift 16.66% 5 Missing ⚠️
...cationScreen/SessionVerificationScreenModels.swift 90.38% 5 Missing ⚠️
...icationScreen/View/SessionVerificationScreen.swift 91.83% 4 Missing ⚠️
...s/FlowCoordinators/OnboardingFlowCoordinator.swift 0.00% 3 Missing ⚠️
...ilsScreen/RoomMemberDetailsScreenCoordinator.swift 0.00% 2 Missing ⚠️
...erDetailsScreen/View/RoomMemberDetailsScreen.swift 50.00% 2 Missing ⚠️
...erProfileScreen/UserProfileScreenCoordinator.swift 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3759      +/-   ##
===========================================
- Coverage    78.61%   78.58%   -0.03%     
===========================================
  Files          793      793              
  Lines        69086    69251     +165     
===========================================
+ Hits         54310    54424     +114     
- Misses       14776    14827      +51     
Flag Coverage Δ
unittests 70.32% <74.48%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanceriu stefanceriu force-pushed the stefan/userVerification branch from 9d7350e to 3dcae93 Compare February 7, 2025 16:03
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, looks good to me! 😎

@stefanceriu stefanceriu force-pushed the stefan/userVerification branch from 171a9a9 to 2a26fb0 Compare February 10, 2025 17:27
@stefanceriu stefanceriu enabled auto-merge (squash) February 10, 2025 17:28
@stefanceriu stefanceriu force-pushed the stefan/userVerification branch from 2a26fb0 to 9c5ed6d Compare February 10, 2025 17:48
@stefanceriu stefanceriu force-pushed the stefan/userVerification branch from 9c5ed6d to 6b42c66 Compare February 10, 2025 17:48
@stefanceriu stefanceriu merged commit 8680d84 into develop Feb 10, 2025
8 checks passed
@stefanceriu stefanceriu deleted the stefan/userVerification branch February 10, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-feature for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Emoji based user verification
2 participants