-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check if user is in room before being able to tag it #17839
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er of a room checked if a user is in a room before tagging it
Closes #17819 |
MadLittleMods
requested changes
Oct 23, 2024
Co-authored-by: Eric Eastwood <[email protected]>
Co-authored-by: Eric Eastwood <[email protected]>
…of looping on users's rooms fixed lint issues
MadLittleMods
requested changes
Oct 24, 2024
Co-authored-by: Eric Eastwood <[email protected]>
Co-authored-by: Eric Eastwood <[email protected]>
Co-authored-by: Eric Eastwood <[email protected]>
MadLittleMods
approved these changes
Oct 25, 2024
MadLittleMods
requested changes
Oct 25, 2024
fixed the query about user membership in a room
MadLittleMods
requested changes
Oct 28, 2024
Co-authored-by: Eric Eastwood <[email protected]>
MadLittleMods
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Just a few formatting things
Co-authored-by: Eric Eastwood <[email protected]>
Thanks for the contribution @lamoboos223 🦝 |
My pleasure, Eric 🤝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a function in room_member handler to check if a user is a member of a room
Check if a user is in a room before tagging it
Fix #17819
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)