Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if user is in room before being able to tag it #17839

Merged
merged 19 commits into from
Oct 30, 2024

Conversation

lamoboos223
Copy link
Contributor

@lamoboos223 lamoboos223 commented Oct 17, 2024

Create a function in room_member handler to check if a user is a member of a room

Check if a user is in a room before tagging it

Fix #17819

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

…er of a room

checked if a user is in a room before tagging it
@lamoboos223 lamoboos223 requested a review from a team as a code owner October 17, 2024 05:38
@CLAassistant
Copy link

CLAassistant commented Oct 17, 2024

CLA assistant check
All committers have signed the CLA.

@lamoboos223
Copy link
Contributor Author

Closes #17819

synapse/rest/client/tags.py Outdated Show resolved Hide resolved
synapse/handlers/room_member.py Outdated Show resolved Hide resolved
synapse/handlers/room_member.py Outdated Show resolved Hide resolved
synapse/rest/client/tags.py Outdated Show resolved Hide resolved
changelog.d/17839.bugfix Outdated Show resolved Hide resolved
lamoboos223 and others added 3 commits October 24, 2024 08:17
changelog.d/17839.bugfix Show resolved Hide resolved
synapse/handlers/room_member.py Outdated Show resolved Hide resolved
synapse/handlers/room_member.py Outdated Show resolved Hide resolved
synapse/handlers/room_member.py Outdated Show resolved Hide resolved
synapse/rest/client/tags.py Show resolved Hide resolved
synapse/handlers/room_member.py Outdated Show resolved Hide resolved
fixed the query about user membership in a room
tests/rest/client/test_tags.py Outdated Show resolved Hide resolved
tests/rest/client/test_tags.py Outdated Show resolved Hide resolved
tests/rest/client/test_tags.py Outdated Show resolved Hide resolved
Copy link
Contributor

@MadLittleMods MadLittleMods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Just a few formatting things

tests/rest/client/test_tags.py Outdated Show resolved Hide resolved
tests/rest/client/test_tags.py Outdated Show resolved Hide resolved
@MadLittleMods MadLittleMods merged commit 3ae80b0 into element-hq:develop Oct 30, 2024
39 checks passed
@MadLittleMods
Copy link
Contributor

Thanks for the contribution @lamoboos223 🦝

@lamoboos223
Copy link
Contributor Author

lamoboos223 commented Oct 30, 2024

My pleasure, Eric 🤝

@MadLittleMods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User can add tag to a room that they are not member of
3 participants