Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: manifest schema validation #28

Merged
merged 5 commits into from
Jan 29, 2024
Merged

fix: manifest schema validation #28

merged 5 commits into from
Jan 29, 2024

Conversation

GeekyEggo
Copy link
Member

  • Fix Actions[].Encoder.Layout could be empty.
  • Fix images incorrectly accepting .gif; should only apply to Actions[].States[].Image.
  • Update error messages to be more consistent.
  • Add plugin UUID to manifest and schema.
  • Add imageDimensions keyword to images in preparation for validating image dimensions via the Maker CLI.

@GeekyEggo GeekyEggo requested a review from ChekTek January 27, 2024 17:39
@GeekyEggo GeekyEggo merged commit ea2c3f7 into main Jan 29, 2024
2 checks passed
@GeekyEggo GeekyEggo deleted the manifest-schema branch January 29, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChekTek ChekTek ChekTek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GeekyEggo @ChekTek