Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fix size #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bug fix size #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ void Client::receiveTask() {
publishEvent(ClientEvent::DISCONNECTED, disconnectionMessage);
return;
} else {
receivedMessage[numOfBytesReceived] = '\0';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. This might solve the issue, but I think it should be done differently. The numOfBytesReceived should be published along with the receivedMessage on the next line of code. This provides greater flexibility for the end-user.

publishEvent(ClientEvent::INCOMING_MSG, receivedMessage);
}
}
Expand Down