Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Crawly.Utils.list_spiders/0 #300

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

oltarasenko
Copy link
Collaborator

The list_spiders function is a bit tricky, it was using info method, that as I see does not work in quite a few cases. Even worse it was just hanging when :shell_defaults.info was called.

I decided to change the function to use .module_info instead, and added some debug loggings

The list_spiders function is a bit tricky, it was using __info__ method,
that as I see does not work in quite a few cases. Even worse it was
just hanging when :shell_defaults.__info__ was called.

I decided to change the function to use .module_info instead, and added
some debug loggings
@oltarasenko oltarasenko force-pushed the fixing_list_sliders2 branch from f3f1d4a to bdb7bc7 Compare July 4, 2024 07:05
Copy link

github-actions bot commented Jul 4, 2024

Tests summary

Finished in 12.2 seconds (0.7s async, 11.5s sync)
Randomized with seed 46562

0 failures (132 tests)
76.66% coverage (75% is the minimum)

Coverage details
Percentage | Module
-----------|--------------------------
     0.00% | Crawly.Fetchers.Splash
     0.00% | Crawly.Loggers.SendToUiBackend
     0.00% | Crawly.Response
     0.00% | Mix.Tasks.Crawly.Gen.Config
     0.00% | String.Chars.Crawly.Request
     0.00% | UtilsTestSpider
    40.00% | PipelineTestSpider
    42.86% | TestSpider
    55.56% | Mix.Tasks.Crawly.Gen.Spider
    60.67% | Crawly.API.Router
    61.54% | Crawly.Models.YMLSpider
    66.67% | Crawly.Models.Job
    75.00% | Crawly.Pipelines.JSONEncoder
    76.47% | Crawly.SimpleStorage
    76.92% | Crawly.Fetchers.CrawlyRenderServer
    77.78% | Crawly.Pipelines.Experimental.SendToUI
    80.00% | Crawly.EngineSup
    80.77% | Crawly
    82.61% | Crawly.Pipelines.WriteToFile
    83.33% | Crawly.Middlewares.UserAgent
    85.42% | Crawly.Utils
    85.53% | Crawly.Engine
    87.50% | Crawly.Application
    87.50% | TestUtils
    88.37% | Crawly.RequestsStorage
    88.46% | Crawly.RequestsStorage.Worker
    89.06% | Crawly.Manager
    90.00% | Crawly.Pipelines.Validate
    91.84% | Crawly.Worker
    92.11% | Crawly.DataStorage
    92.86% | Crawly.DataStorage.Worker
   100.00% | Crawly.Fetchers.Fetcher
   100.00% | Crawly.Fetchers.HTTPoisonFetcher
   100.00% | Crawly.ManagerSup
   100.00% | Crawly.Middlewares.AutoCookiesManager
   100.00% | Crawly.Middlewares.DomainFilter
   100.00% | Crawly.Middlewares.RequestOptions
   100.00% | Crawly.Middlewares.RobotsTxt
   100.00% | Crawly.Middlewares.SameDomainFilter
   100.00% | Crawly.Middlewares.UniqueRequest
   100.00% | Crawly.ParsedItem
   100.00% | Crawly.Pipeline
   100.00% | Crawly.Pipelines.CSVEncoder
   100.00% | Crawly.Pipelines.DuplicatesFilter
   100.00% | Crawly.Request
   100.00% | Crawly.Settings
   100.00% | Crawly.Spider
-----------|--------------------------
    76.66% | Total

@oltarasenko oltarasenko merged commit 0fd9aa6 into master Jul 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant