-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure top heading action icon is to right when width allows #2076
Ensure top heading action icon is to right when width allows #2076
Conversation
📦 Docs artifacts are ready: https://github.com/elixir-lang/ex_doc/actions/runs/12994716408/artifacts/2492250034 |
flex-wrap: nowrap; | ||
gap: 32px; | ||
align-items: flex-start; | ||
.icon-action { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is invalid, as we are not using a preprocessor, so I want ahead and remove it, as it seems not necessary. Please double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nested selectors are now supported in CSS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correcting my edited comment: the flex-start and padding-top is necessary for correct vertical alignment when the heading runs into two lines or more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, fantastic, I will add it back! The tooling is complaining, so we may need to either update it or move it to the top. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DavidOliver this seems to do the trick: b0a2412
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great - thanks!
Only
top-heading
headings are affected, and only when content is wider than 600px.Callback/function headings have not been changed; they continue to always wrap so as to prioritise text display.
A container has been registered in the layout styles, meaning that we can easily conditionally apply styles based on the content width irrespective of whether or not the sidebar is shown.
simplescreenrecorder-2025-01-27_18.13.53.mp4